Change in openvpn[master]: GHA: increase verbosity for make check
A message that is not in the archive (sent off-list or not yet received): gerrit.1703674237000.Ie44a4b750605c4cc3ac1f75e1fa5ab85804ffa71@...2715...
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/485?usp=email
to review the following change.
Change subject: GHA: increase verbosity for make check
......................................................................
GHA: increase verbosity for make check
Make sure we get to see the test-suite.log on
failure.
---
M .github/workflows/build.yaml
1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/85/485/1
.github/workflows/build.yaml +5 -5
@@ -163,7 +163,7 @@ - name: make all run: make -j3 - name: make check - run: make check + run: make check VERBOSE=1 ubuntu-clang-asan: strategy:
@@ -190,7 +190,7 @@ - name: make all run: make -j3 - name: make check - run: make check + run: make check VERBOSE=1 macos: strategy:
@@ -239,7 +239,7 @@ - name: make all run: make -j4 - name: make check - run: make check + run: make check VERBOSE=1 msvc: strategy:
@@ -348,7 +348,7 @@ - name: make all run: make -j3 - name: make check - run: make check + run: make check VERBOSE=1 mbedtls3: strategy:
@@ -399,4 +399,4 @@ - name: make all run: make -j3 - name: make check - run: make check + run: make check VERBOSE=1
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/485?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie44a4b750605c4cc3ac1f75e1fa5ab85804ffa71
Gerrit-Change-Number: 485
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-MessageType: newchange
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/485?usp=email )
Change subject: GHA: increase verbosity for make check
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/485?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie44a4b750605c4cc3ac1f75e1fa5ab85804ffa71
Gerrit-Change-Number: 485
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Comment-Date: Fri, 05 Jan 2024 13:54:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/485?usp=email )
The change is no longer submittable: Code-Review is unsatisfied now.
Change subject: GHA: increase verbosity for make check
......................................................................
Patch Set 1: -Code-Review
(1 comment)
Patchset:
PS1:
Retracting my previous ACK. I mixed up cmake VERBOSE=1 with the V=1 of make.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/485?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie44a4b750605c4cc3ac1f75e1fa5ab85804ffa71
Gerrit-Change-Number: 485
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Comment-Date: Fri, 05 Jan 2024 14:09:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/485?usp=email )
Change subject: GHA: increase verbosity for make check
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
Quoted 1 line
Retracting my previous ACK. I mixed up cmake VERBOSE=1 with the V=1 of make.
I had still a backout of the serial test in my branch, so I did had the generated code for this in my tree:
tests/unit_tests/openvpn/Makefile: test x"$$VERBOSE" = x || cat $(TEST_SUITE_LOG);
So it actually works.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/485?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie44a4b750605c4cc3ac1f75e1fa5ab85804ffa71
Gerrit-Change-Number: 485
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Comment-Date: Fri, 05 Jan 2024 14:19:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: plaisthos <[email protected]...>
Gerrit-MessageType: comment
PATCH 1/1 GHA: increase verbosity for make check
In reply to a message not in the archiveFrom: Frank Lichtenheld <[email protected]...>
Make sure we get to see the test-suite.log on
failure.
---
This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/485
This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above):
Arne Schwabe <[email protected]...>
.github/workflows/build.yaml +5 -5
@@ -163,7 +163,7 @@ - name: make all run: make -j3 - name: make check - run: make check + run: make check VERBOSE=1 ubuntu-clang-asan: strategy:
@@ -190,7 +190,7 @@ - name: make all run: make -j3 - name: make check - run: make check + run: make check VERBOSE=1 macos: strategy:
@@ -239,7 +239,7 @@ - name: make all run: make -j4 - name: make check - run: make check + run: make check VERBOSE=1 msvc: strategy:
@@ -348,7 +348,7 @@ - name: make all run: make -j3 - name: make check - run: make check + run: make check VERBOSE=1 mbedtls3: strategy:
@@ -399,4 +399,4 @@ - name: make all run: make -j3 - name: make check - run: make check + run: make check VERBOSE=1
[Openvpn-devel] [PATCH applied] Re: GHA: increase verbosity for make check
serial-tests change is only in master, so this only goes to master (for now).
Your patch has been applied to the master branch.
commit 55c734d7c02f9778321af550a9e0d12638fe12a0
Author: Frank Lichtenheld Date: Fri Jan 5 15:23:39 2024 +0100
GHA: increase verbosity for make check
Signed-off-by: Frank Lichtenheld <[email protected]...>
Acked-by: Arne Schwabe <[email protected]...>
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg27943.html
Signed-off-by: Gert Doering <[email protected]...>--
kind regards,
Gert Doering
cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/485?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by plaisthos
Change subject: GHA: increase verbosity for make check
......................................................................
GHA: increase verbosity for make check
Make sure we get to see the test-suite.log on
failure.
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg27943.html
---
M .github/workflows/build.yaml
1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/85/485/2
.github/workflows/build.yaml +5 -5
@@ -163,7 +163,7 @@ - name: make all run: make -j3 - name: make check - run: make check + run: make check VERBOSE=1 ubuntu-clang-asan: strategy:
@@ -190,7 +190,7 @@ - name: make all run: make -j3 - name: make check - run: make check + run: make check VERBOSE=1 macos: strategy:
@@ -239,7 +239,7 @@ - name: make all run: make -j4 - name: make check - run: make check + run: make check VERBOSE=1 msvc: strategy:
@@ -348,7 +348,7 @@ - name: make all run: make -j3 - name: make check - run: make check + run: make check VERBOSE=1 mbedtls3: strategy:
@@ -399,4 +399,4 @@ - name: make all run: make -j3 - name: make check - run: make check + run: make check VERBOSE=1
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/485?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie44a4b750605c4cc3ac1f75e1fa5ab85804ffa71
Gerrit-Change-Number: 485
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: newpatchset
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/485?usp=email )
Change subject: GHA: increase verbosity for make check
......................................................................
GHA: increase verbosity for make check
Make sure we get to see the test-suite.log on
failure.
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg27943.html
---
M .github/workflows/build.yaml
1 file changed, 5 insertions(+), 5 deletions(-)
.github/workflows/build.yaml +5 -5
@@ -163,7 +163,7 @@ - name: make all run: make -j3 - name: make check - run: make check + run: make check VERBOSE=1 ubuntu-clang-asan: strategy:
@@ -190,7 +190,7 @@ - name: make all run: make -j3 - name: make check - run: make check + run: make check VERBOSE=1 macos: strategy:
@@ -239,7 +239,7 @@ - name: make all run: make -j4 - name: make check - run: make check + run: make check VERBOSE=1 msvc: strategy:
@@ -348,7 +348,7 @@ - name: make all run: make -j3 - name: make check - run: make check + run: make check VERBOSE=1 mbedtls3: strategy:
@@ -399,4 +399,4 @@ - name: make all run: make -j3 - name: make check - run: make check + run: make check VERBOSE=1
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/485?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie44a4b750605c4cc3ac1f75e1fa5ab85804ffa71
Gerrit-Change-Number: 485
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: merged